Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit required and newer configuration options added to the schema, along with versioning of the schema itself #67

Open
hedss opened this issue Aug 9, 2019 · 1 comment

Comments

@hedss
Copy link
Contributor

hedss commented Aug 9, 2019

No description provided.

@hedss hedss changed the title Audit required and newer configuration options added to the schema Audit required and newer configuration options added to the schema, along with versioning of the schema itself Aug 9, 2019
@hedss
Copy link
Contributor Author

hedss commented Aug 9, 2019

For example sshKeys is missing, but a valid configurable option. However, as @dfunckt says:

You can’t really add a new required property for example, because that would prevent eg the CLI from configuring an older OS nor make a required one optional, because the OS would bork without its presence — we have this issue for the “mixpanelToken” attribute now

This is because the different versions of the OS potentially 'require' different config options. Hence, we also need to version it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant