Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CoW AMM multisig with tx batch #181

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

agualis
Copy link
Collaborator

@agualis agualis commented Nov 22, 2024

Disclaimer:
Note that this feature is a proof of concept and we have only tested the happy paths.
Once we release V3, we will improve the design and cover all the edge cases. TODO examples:

  • Proper manage multisigs via Wallet Connect
  • Track Safe transaction hash in the Recent Transactions list (now we lose the transaction page if the user leaves the page once the multisig process has been started)

Required setup:
It is required to have a multisig Safe Account with 2 min confirmations.

How to test:

  1. Open https://app.safe.global/
  2. Go to Apps > My custom apps > click Add custom Safe App
  3. Input the preview URL of the current PR in the Safe App Url* input: https://mono-test-v3-git-feat-cowammbatch-balancer.vercel.app/
  4. Click Add and then open Safe App
  5. Open a Gnosis CoW AMM pool and Add liquidity

Example of batch of 3 transactions (2 token approvals + 1 add liquidity transaction):

batchWithApprovals

@agualis agualis self-assigned this Nov 22, 2024
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mono-beets-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:39am
mono-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:39am
mono-test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:39am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant