Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for tokenlist generation script for start getting ready for multichain #357

Open
wants to merge 249 commits into
base: master
Choose a base branch
from

Conversation

TomAFrench
Copy link
Contributor

@TomAFrench TomAFrench commented Jun 23, 2021

Taking a view that much of this repo is based around V1 and is no longer necessary as V2 becomes more mature (No more V1 LM caps and registry.homestead.json is pretty much static now), I've refactored some of this codebase to focus more on easily generating tokenlists.

This is just a first pass and it will need some more attention to address:

  • add support for Polygon, Arbitrum, etc.
  • simplify the json files for tokens to account for simplifications in liquidity mining program.

@TomAFrench TomAFrench force-pushed the refactor-for-multichain branch from 390e34f to 1569c37 Compare June 24, 2021 00:06
@TomAFrench TomAFrench force-pushed the refactor-for-multichain branch from 1569c37 to 4c35ae1 Compare June 24, 2021 00:08
feat: add script to merge tokenlists
feat: pull metadata from Coingecko
* master: (28 commits)
  Generate config
  Generate config
  Dirty hotfix for Trust Wallet logos
  Add CHEESE token and LBP metadata
  Add GRO token
  Fix boundaries of wDGLD logo
  Generate config
  List EURS and wDGLD on the Trade UI
  Remove checksums from EGL and wDGLD logo entries
  Generate config
  generate bal-for-gas json for the frontend
  Generate config
  Add EGL and wDGLD price feeds
  Add EGL and wDGLD to Invest UI
  Add logos for EGL and wDGLD
  Generate config
  Add wstETH to vetted list
  Add LDO, stETH, wstETH to index.json
  Update listed.json
  feat: add LDO, stETH, wstETH
  ...
@rabmarut
Copy link
Contributor

rabmarut commented Dec 3, 2021

This PR has been waiting a long time, and we desperately need to start managing lists for multiple networks, so I'd really like to get it merged soon.

My primary concern is breaking the V1 UI - there are a few things being removed here that are pretty critical for the legacy pools (among which is the gigantic AAVE/WETH pool). But I agree that we shouldn't carry them around in master just for rare legacy support. Perhaps we should create a V1 branch off the current master, point the legacy UI at it, and then start prepping this refactor for merge. What do you think, @TomAFrench?

@TomAFrench
Copy link
Contributor Author

Ah yeah, looks like the V1 repo is pulling directly from gh rather than from fleek. We'll need to lock it to a particular tag or branch in that case as you say.

The script will need some modifications to allow it to run in CI as well as currently network selection is done by commenting out lines of code.

* master:
  Manually generate tokenlists
  Add boosted pool tokens to lists (with logos)
  Generate config
  Update index.json
  Add files via upload
  Delete 0xCFEAead4947f0705A14ec42aC3D44129E1Ef3eD5.png
  add NOTE icon to list
  NOTE icon
  added two new pools to whitelist NOTE/NEXO
  Generate config
  feat: add FEI and TRIBE to trade UI
  Generate config
  Generate config
  Generate config
  Add ROBOT to Trade UI
  Generate config
  Generate config
  Add KNX to logo index
  feat: add KNX token
zekraken-bot and others added 30 commits March 14, 2023 11:40
Add tetu boosted matic pool icons
move icons to the proper folder
update pool metadata after the redeployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.