Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 514 #515

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Fix issue 514 #515

merged 1 commit into from
Aug 13, 2023

Conversation

teddychao
Copy link
Contributor

@teddychao teddychao commented Aug 13, 2023

Fixes #514.

Introduction

The issue appears as PsPM cannot be started when it is called offline. The reason of this issue is, at line 63 and 66 the script is terminated if it is offline, which will not assign values to the expected values sts and version_of_pspm.

Method

Under the offline situation, the variables sts and version_of_pspm should be still assigned in pspm_version, before the script pspm_version is terminated.

Results

At line 63 and 66, the return behaviour is removed, because the return values should be assigned at line 73--79.
The new_v is not assigned because version checking cannot be performed.
PsPM can be started when offline with the new code, after testing.

image

@teddychao teddychao linked an issue Aug 13, 2023 that may be closed by this pull request
@teddychao teddychao requested a review from dominikbach August 13, 2023 17:06
@teddychao teddychao self-assigned this Aug 13, 2023
@teddychao teddychao added the Bug Something isn't working label Aug 13, 2023
@teddychao teddychao added this to the v6.1 milestone Aug 13, 2023
@teddychao teddychao marked this pull request as ready for review August 13, 2023 17:06
@teddychao teddychao added Completed & Waiting for Review Completed and waiting for review and removed Bug Something isn't working labels Aug 13, 2023
@dominikbach dominikbach merged commit e10f8da into develop Aug 13, 2023
@dominikbach dominikbach deleted the 514-pspm-does-not-start-offline branch August 13, 2023 18:12
@teddychao teddychao added Solved and removed Completed & Waiting for Review Completed and waiting for review labels Aug 20, 2023
@teddychao teddychao removed the Solved label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PsPM does not start offline
2 participants