Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514.
Introduction
The issue appears as PsPM cannot be started when it is called offline. The reason of this issue is, at line 63 and 66 the script is terminated if it is offline, which will not assign values to the expected values
sts
andversion_of_pspm
.Method
Under the offline situation, the variables
sts
andversion_of_pspm
should be still assigned inpspm_version
, before the scriptpspm_version
is terminated.Results
At line 63 and 66, the
return
behaviour is removed, because the return values should be assigned at line 73--79.The
new_v
is not assigned because version checking cannot be performed.PsPM can be started when offline with the new code, after testing.