Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tong/395 phase 2 modal #410

Merged
merged 6 commits into from
Nov 30, 2024
Merged

Tong/395 phase 2 modal #410

merged 6 commits into from
Nov 30, 2024

Conversation

supertong
Copy link
Contributor

Demo:

image image image image image image image image image image image image image image

@supertong supertong changed the base branch from v0.3.x to main November 29, 2024 12:46
@jrwbabylonlab jrwbabylonlab mentioned this pull request Nov 29, 2024
Closed
gbarkhatov
gbarkhatov approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@gbarkhatov gbarkhatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@totraev totraev merged commit 299a1c4 into main Nov 30, 2024
1 check passed
@totraev totraev deleted the tong/395-phase-2-modal branch November 30, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@gbarkhatov gbarkhatov gbarkhatov approved these changes

@totraev totraev totraev approved these changes

@jeremy-babylonlabs jeremy-babylonlabs Awaiting requested review from jeremy-babylonlabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@supertong @totraev @gbarkhatov @jrwbabylonlab