Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server.go instead of manually setup in tests/setup.go #178

Open
jrwbabylonlab opened this issue Jun 17, 2024 · 0 comments
Open

Use server.go instead of manually setup in tests/setup.go #178

jrwbabylonlab opened this issue Jun 17, 2024 · 0 comments
Labels
good first issue Good for newcomers low

Comments

@jrwbabylonlab
Copy link
Collaborator

In the tests/setup.go, we are manually injecting the middleware for tests. But this can be avoided as we already does that in the server.go.

Try remove the service set up in the test files, especially r.Use for middlewares
@jrwbabylonlab jrwbabylonlab added good first issue Good for newcomers low labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrwbabylonlab