Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: set up Dockerfile for bcd #10

Merged
merged 3 commits into from
Jun 14, 2024
Merged

docker: set up Dockerfile for bcd #10

merged 3 commits into from
Jun 14, 2024

Conversation

SebastianElvis
Copy link
Member

@SebastianElvis SebastianElvis commented Jun 11, 2024 •
edited
Loading

This PR fixes the Dockerfile for the bcd program. It is the prerequisite for the Euphrates 0.3.0 local deployment.

Test plan: sudo make build-docker

gusin13
gusin13 approved these changes Jun 14, 2024
View reviewed changes
Copy link

@gusin13 gusin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

curious where is this planned to be deployed btw, my understanding was this will be used in finality-provider but that is not ready yet (as we just integrated wasmd)

@SebastianElvis
Copy link
Member Author

lgtm 👍

curious where is this planned to be deployed btw, my understanding was this will be used in finality-provider but that is not ready yet (as we just integrated wasmd)

It will be used in babylon-deployment (once we split the IBC relayer and the consumer chain in two docker containers)

@SebastianElvis SebastianElvis merged commit 439aae4 into main Jun 14, 2024
2 of 5 checks passed
@SebastianElvis SebastianElvis deleted the dockerfile branch June 14, 2024 05:00
maurolacy
maurolacy reviewed Jun 14, 2024
View reviewed changes
Copy link

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy left review comments

@gusin13 gusin13 gusin13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianElvis @maurolacy @gusin13