Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run prettier-tslint on a file in a path with the name "node_modules" #21

Open
mschnee opened this issue Oct 17, 2018 · 3 comments

Comments

@mschnee
Copy link

mschnee commented Oct 17, 2018

The following does not work:

prettier-tslint check ./packages/node_modules/@scope/packageName/src/path/to/file.ts

Prettier addresses this by having a --with-node-modules option, which changes the default filter.

This is fixed by #20

@azz
Copy link
Owner

azz commented Oct 22, 2018

Curious what the use case for formatting files in node_modules is? Wouldn't you just use yarn workspaces or lerna bootstrap?

@mschnee
Copy link
Author

mschnee commented Nov 3, 2018

Very much like the folks working on PouchDB, neither lerna nor yarn workspaces actually suit my needs. The specific reasons for me include unmanageable build times (hours versus minutes), problems in creating distribution tarballs that include all bundledDependencies, and incompatibilities with some automation and tooling.

Not that I don't use lerna on some projects, just that I'm working with some where it's not the right tool.

@aleclarson
Copy link
Collaborator

aleclarson commented Dec 10, 2018

Why wouldn't you lint your files before installing them elsewhere?

If not your files: Why are you linting third-party files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants