Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cargo features #215

Open
EdJoPaTo opened this issue Sep 17, 2024 · 1 comment
Open

Improve cargo features #215

EdJoPaTo opened this issue Sep 17, 2024 · 1 comment

Comments

@EdJoPaTo
Copy link
Collaborator

#214 removes the implicit features of the dependencies.

Maybe the names can be improved / simplified (mentioning telegram in the telegram related crate is superfluous).

Maybe the default feature can be removed? Using the async client requires disabling the default features which is a bit annoying. Maybe always require adding the wanted feature?

@EdJoPaTo EdJoPaTo changed the title Improve Features Improve cargo features Sep 17, 2024
@EdJoPaTo
Copy link
Collaborator Author

async-client and sync-client or client-async and client-sync?
Maybe go with the file names of the modules: client_ureq and client_reqwest and trait_async / trait_sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant