Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aya-dev as a submodule of this project? #27

Open
imkiva opened this issue Nov 10, 2022 · 8 comments
Open

Add aya-dev as a submodule of this project? #27

imkiva opened this issue Nov 10, 2022 · 8 comments
Labels
question Further information is requested

Comments

@imkiva
Copy link
Member

imkiva commented Nov 10, 2022

We just hit git submodule update instead of copying bnf files.

@imkiva imkiva added the question Further information is requested label Nov 10, 2022
@imkiva imkiva changed the title Make aya-dev a submodule Add aya-dev as a submodule of this project? Nov 10, 2022
@ice1000
Copy link
Member

ice1000 commented Nov 10, 2022

Probably won't work, because I feel like this implies depending on the source code of Aya. Then you'll have to deal with ij-parsing-core.

@ice1000
Copy link
Member

ice1000 commented Nov 10, 2022

We can use a download task to grab the bnf instead

@ice1000
Copy link
Member

ice1000 commented Nov 18, 2022

A better way is to add submodule and use it for gradlew pTML when building this project

@ice1000
Copy link
Member

ice1000 commented Nov 18, 2022

But we can also clone it in the build process

@imkiva
Copy link
Member Author

imkiva commented Nov 18, 2022

What is pTML

@imkiva
Copy link
Member Author

imkiva commented Nov 18, 2022

publishToMavenLocal okay

@imkiva
Copy link
Member Author

imkiva commented Nov 18, 2022

I suggest use submodule with Gradle composite build (works both in CI and local machine)

@ice1000
Copy link
Member

ice1000 commented Nov 18, 2022

Right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants