Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing binaries in the root of the archive #1621

Open
ruben-arts opened this issue Dec 10, 2024 · 1 comment
Open

Allowing binaries in the root of the archive #1621

ruben-arts opened this issue Dec 10, 2024 · 1 comment

Comments

@ruben-arts
Copy link

Hey team! Thanks for the great tool!

We used to always put our binaries directly in the root of our .tar.gz archives. dist seems to be hard coded to always add a subdir for the non zip files. We're trying to completely move to cargo-dist but we need to keep our already released tools working. As we have a self-update cli command that requires this setup.

I already made a fork and implemented a first version for myself to test it in our workflow: main...ruben-arts:cargo-dist:feature/allow_binaries_in_root_of_tar

Let me know if you would be open to a contribution of this sort.

@duckinator
Copy link
Contributor

duckinator commented Dec 10, 2024

Hey! What you have right now looks great. You can submit a PR and I'll make a follow-up PR myself adding a test or two and documentation.

It may take us a little bit to merge it, because I want to investigate how it interacts with dist's updater feature (so I can make sure they play nice together), but it's definitely functionality we want and your code is a very good starting point. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants