Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick docs fix to the zap example #311

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

konradjniemiec
Copy link

This example doesn't compile—I get: missing dataset name

This example doesn't compile—I get: `missing dataset name`

Signed-off-by: Konrad Niemiec <[email protected]>
@lukasmalkmus
Copy link
Collaborator

lukasmalkmus commented May 22, 2024

Hi @konradjniemiec 👋

Thanks for the contribution! What you're describing is actually explained a couple of lines before: https://github.com/axiomhq/axiom-go/pull/311/files#diff-65932b4d21b82ce597f2aa3c53c235560d9da11836ed720eb5ca8355d4678859R23-R25.

Do you think this is not very obvious and we should improve it? Like do just one code block or something similar? What about other code examples like the ones in examples or GoDoc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants