libCEED integration #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangrimberg
force-pushed
the
sjg/libceed-integration-dev
branch
from
edde218 to
eb5ccd3
Compare
sebastiangrimberg
force-pushed
the
sjg/libceed-integration-dev
branch
from
eb5ccd3 to
1cc8052
Compare
…d operator assembly (WIP)
… operator AddMult with non-unit coefficient
…arately from integration-based operators
sebastiangrimberg
force-pushed
the
sjg/libceed-integration-dev
branch
from
1cc8052 to
f764f01
Compare
sebastiangrimberg
force-pushed
the
sjg/libceed-integration-dev
branch
from
f764f01 to
b2b2d4a
Compare
Includes some test meshes in 2D and 3D, in test/unit/mesh.
…st of the Palace application
…taneous unordered_map::find while also inserting
…, tested across many meshes/finite element spaces in the unit tests
…ng the palace::FiniteElementSpace class which inherits from mfem::ParFiniteElementSpace and adds a UUID so each instance of the class can be uniquely identified Adds UUID generation functionality using https://github.com/mariusbancila/stduuid, one choice of many for a light-weight, permissively licensed, reliable UUID generator. We only need weak guarantees on uniqueness, since we won't be generating millions or billions of objects requiring unique identification.
… library dependency
…ocess-local block of the operator, not on the parallel assembled one)
Unit testing and benchmarking libCEED integration with Catch2
Add GitHub Actions workflow for unit tests
This was referenced Oct 3, 2023
Closed
hughcars
reviewed
Oct 9, 2023
There was a problem hiding this comment.
It's very hard to see much into the correctness of the Q functions, aside from some basic pattern matching, so am relying on the correctness of the tests. Very good there'll now be a unit test framework in place.
The only largish change I could see is doing away comes from reducing the indirection with the new bilinear form. Breaking from the mfem version it's possible to make a much neater interface.
…e and use return value from emplace_back()
…dientIntegrator for (grad(u), v) with u in H1 and v in vector H1
…ent in GradFluxErrorEstimator, enable partial assembly for BilinearForms, ensure thread-safety in loop over elements)
…e rule modifications for forming RHS
hughcars
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Changes on the first decimal place seem surprising, but note for posterity: the regeneration here compared to mainline is due to regeneration necessary for b2b2d4a in updating the quadrature orders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate libCEED for operator partial assembly directly into Palace rather than via patches on MFEM, for both long-term maintainability and better integration with the specialized use within Palace.
All integrators are now assembled via libCEED using user-defined QFunctions rather than using the predefined MFEM integrators. This allows for a single code path for both CPU and device-based partial and full assembly. The
"Device"configuration file option now only configures themfem::Device(ascpu,cuda,hip, etc.) while the new"Backend"option configures the libCEED backend, with appropriate defaults based on the value of"Device"for the typical end-user.TODO:
Resolves #101 (updates libCEED and MFEM dependencies)