Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Dimension support #43

Open
linshu opened this issue Apr 15, 2017 · 7 comments
Open

Configurable Dimension support #43

linshu opened this issue Apr 15, 2017 · 7 comments

Comments

@linshu
Copy link

linshu commented Apr 15, 2017

Is there any plan to support configurable dimension, which we can configure different dimensions through a conf file or something similar?
@mindstorms6
Copy link
Contributor

Does #37 do what you're looking for?

@linshu
Copy link
Author

linshu commented Apr 17, 2017

I want a fully configuration dimension schema, not something hardcoded like "FixedDimension". Also, I can really add as many as possible (only limited by AWS cloudwatch) dimensions.
I put the review on the lines I want to change in #37
Thanks.

@Poil
Copy link

Poil commented Apr 26, 2017

You can try my old 2015 dev that was allowing that https://github.com/Poil/collectd_to_cloudwatch

linshu pushed a commit to linshu/collectd-cloudwatch that referenced this issue Apr 27, 2017
Create a framework to add any dimension if needed
ca2f6aa 
Issue awslabs#43
@linshu linshu mentioned this issue Apr 27, 2017
Merged
@Fodoj
Copy link

Fodoj commented May 3, 2017

@linshu I see you implemented the feature. Do you plan to make a PR to this repo?

@linshu
Copy link
Author

linshu commented May 6, 2017

@Fodoj Yes, I plan to do that. I am just doing more tests and see if anything I missed. If you think it is good, I can do the PR immediately. Thanks.

linshu added a commit to linshu/collectd-cloudwatch that referenced this issue May 6, 2017
@linshu
Remove execute permission of files.
a8d6246 
Issue awslabs#43
linshu added a commit to linshu/collectd-cloudwatch that referenced this issue May 31, 2017
@linshu
Add Hostname dimension.
6f99f7e 
Issue awslabs#43
This was referenced May 31, 2017
Merged
Open
@linshu
Copy link
Author

linshu commented May 31, 2017

@Fodoj I opened a PR for this issue. Please take a look at it. Thanks.

linshu added a commit to linshu/collectd-cloudwatch that referenced this issue Jun 1, 2017
@linshu
Move dimension handler from class variable to instance variable. Move…
a76fba8 
… dimension

as a local variable to return
awslab Issue awslabs#43
linshu added a commit to linshu/collectd-cloudwatch that referenced this issue Sep 27, 2017
@linshu
Add explanation of how to use Flexible Dimensions per review comment.
8f575f8 
    Issue awslabs#43
linshu added a commit to linshu/collectd-cloudwatch that referenced this issue Sep 27, 2017
@linshu
Add explanation of how to use Flexible Dimensions per review comment.
e5a2cf9 
    Issue awslabs#43
linshu pushed a commit to linshu/collectd-cloudwatch that referenced this issue Jan 22, 2018
@linshu
Create a framework to add any dimension if needed
64c165d 
Issue awslabs#43
linshu added a commit to linshu/collectd-cloudwatch that referenced this issue Jan 22, 2018
@linshu
Remove execute permission of files.
2f77f00 
Issue awslabs#43
linshu added a commit to linshu/collectd-cloudwatch that referenced this issue Jan 22, 2018
@linshu
Add Hostname dimension.
defdc0b 
Issue awslabs#43
linshu added a commit to linshu/collectd-cloudwatch that referenced this issue Jan 22, 2018
@linshu
Move dimension handler from class variable to instance variable. Move…
5644fec 
… dimension

as a local variable to return
awslab Issue awslabs#43
linshu added a commit to linshu/collectd-cloudwatch that referenced this issue Jan 22, 2018
@linshu
Add explanation of how to use Flexible Dimensions per review comment.
c4a2519 
    Issue awslabs#43
linshu added a commit to linshu/collectd-cloudwatch that referenced this issue Jan 22, 2018
@linshu
Remove unit in the report.
c2ab580 
Issue awslabs#43
@linshu
Copy link
Author

linshu commented Apr 21, 2018

What's update for this issue? Anything else are we waiting for from my side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Fodoj @mindstorms6 @linshu @Poil