Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of version and type on deserialization base64 encoding error #42

Closed
6 tasks
seebees opened this issue Sep 19, 2019 · 1 comment · Fixed by #154
Closed
6 tasks

Verification of version and type on deserialization base64 encoding error #42

seebees opened this issue Sep 19, 2019 · 1 comment · Fixed by #154
Assignees

Comments

@seebees
Copy link
Contributor

seebees commented Sep 19, 2019

When deserializing an encrypted blob.
The version and type are fixed.
However binary data is often stored as a base64 encoded string.
This is especially true of the AWS Encryption SDK Java functions encryptString.

Customers will take a base64 encoded string and pass this to a decrypt function without the proper decoding, resulting in a failure.

Since the version and type are fixed,
and these values can be translated into their base64 equivalent,
when the blob is rejected as invalid,
the notification can suggest that this failure is an encoding issue.

This may be codified into the specification
or as a recommendation for implementations.

Changes needed:

@seebees seebees added this to the keyrings milestone May 22, 2020
@acioc
Copy link
Contributor

acioc commented May 26, 2020

Implementation recommendations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants