Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to macos-13 and 15, use DRY for Mac jobs #2090

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Conversation

sirknightj
Copy link
Contributor

@sirknightj sirknightj commented Dec 4, 2024

Issue #, if available:

What was changed?

  • Actually use the GCC compiler for Mac-GCC jobs.
  • Factor out the Mac jobs to use the matrix strategy for more maintainable code

Why was it changed?

How was it changed?

  • CI file was modified to include the changes above.
  • Note that the GCC+Mac+Unit Tests combination was skipped. The GCC job previously used Clang 14. Now that it actually correctly uses GCC-14, AWS CRT CPP does not support this combination of GCC on Apple Silicon Macs: Build Issue with M1 MacOS and GCC aws-crt-cpp#605. Note that a different compile error for AWS SDK CRT occurs for GCC on the Intel Macs too:
/Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/dispatch/queue.h:103:1: error: unknown type name 'dispatch_queue_t'; did you mean 'dispatch_time_t'?
  103 | DISPATCH_DECL_SUBCLASS(dispatch_queue_global, dispatch_queue);
      | ^~~~~~~~~~~~~~~~~~~~~~

What testing was done for the changes?

  • Having GitHub actions run the updated CI.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj added CI Automated testing v1.11.1 labels Dec 4, 2024
@sirknightj sirknightj changed the title Upgrade to macos-13 and 15, use DRY for Mac jobs, use docker for Ubuntu Linux jobs Upgrade to macos-13 and 15, use DRY for Mac jobs Dec 5, 2024
@sirknightj sirknightj marked this pull request as ready for review December 5, 2024 01:28
@sirknightj
Copy link
Contributor Author

Warning: Formula gst-plugins-base was renamed to gstreamer.
Warning: Formula gst-plugins-good was renamed to gstreamer.
Warning: Formula gst-plugins-bad was renamed to gstreamer.
Warning: Formula gst-plugins-ugly was renamed to gstreamer.
Warning: Formula gst-libav was renamed to gstreamer.

Copy link
Contributor

@niyatim23 niyatim23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sirknightj sirknightj merged commit 2dca68a into develop Dec 5, 2024
40 checks passed
@sirknightj sirknightj deleted the ci-fixes branch December 5, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Automated testing v1.11.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants