SDP Attribute Fixes #2082
Merged
SDP Attribute Fixes #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix nack pli overwrite bug * create generic strings instead of hard coding * remove stale comment in tests
stefankiesz
changed the title
stefankiesz
changed the title
sirknightj
approved these changes
Nov 21, 2024
unicornss
approved these changes
Nov 22, 2024
|
end-to-end testing should confirm the functionality of both H.264 and H.265 pipelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
Issue #, if available:
What was changed?
(in addition to original PR changes)
nack pliattribute for h.264.rtcp-fbattribute name for h.265.nack pliandnackattribute lines used to validate SDP now end with anSDP_LINE_SEPARATOR("\r\n") to consider that one of the lines might be a substring of another.nack pliandnacklines are present in the SDP. Previously, the test passed if one of them was missing.Why was it changed?
To correct the above issues and properly test that
nack pliandnackfeedback attributes are set in the SDP.How was it changed?
By making the appropriate SDP changes and accounting for missed cases in the tests.
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.