Memory Optimization - ICE Agent Stats (#1947)

[stefankiesz]

• Original PR: Ice memory reduction - enable ice stats flag #1947

Issue #, if available:

What was changed?

• Ice agent stats are now back to being enabled by default.
• Added ENABLE_STATS_CALCULATION_CONTROL CMake option to support enabling/disabling stats at runtime.
• Added unit tests to test these new paths.
• Updated ReadMe to reflect the new changes.

Why was it changed?

• Leaving stats calculations to be on by default for backwards-compatibility purposes.
• To ensure the new enableIceStats value is used as intended, a compile-time flag is required to enable its use for run-time control over enabling/disabling stats.
  • This is to avoid the risk of using garbage value for enableIceStats in the case that it was not initialized.
  • This will keep the SDK backwards-compatible with applications.

How was it changed?

• #ifdef's were added to check for the ENABLE_STATS_CALCULATION_CONTROL flag before using the enableIceStats value.

What testing was done for the changes?

• Allowing the new unit tests to pass in the CI.
• Locally testing all 4 possible paths:
  1. ENABLE_STATS_CALCULATION_CONTROL=FALSE and enableIceStats=TRUE
  2. ENABLE_STATS_CALCULATION_CONTROL=FALSE and enableIceStats=FALSE
  3. ENABLE_STATS_CALCULATION_CONTROL=TRUE and enableIceStats=TRUE
  4. ENABLE_STATS_CALCULATION_CONTROL=TRUE and enableIceStats=FALSE

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.