Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transport-wide RTCP Feedback Message parsing #2024

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

moninom1
Copy link
Contributor

@moninom1 moninom1 commented Jul 3, 2024

Issue #, if available:
The TWCC RTCP feedback message - Status Vector Chunk parsing was extracting incorrect symbol list.
Reference for parsing.

Currently parsed output :

packetChunk 58709 [0xe555]
1[chunk type] 1[symbol size] 10 01 01 01 01 01 01

Incorrect statusVector statusSymbol read - 2, 2, 0, 0, 0, 0, 0

Expected Output :

packetChunk 58709 [0xe555]
1[chunk type] 1[symbol size] 10 01 01 01 01 01 01

statusVector statusSymbol read - 2, 1, 1, 1, 1, 1, 1

What was changed?
Updated the packet parsing.

Why was it changed?
It is updated for correct packet chunk parsing.

How was it changed?
The mask used for extracting status symbol is updated along with the position from where the bits need to be read.

What testing was done for the changes?
Verified by running demo & printing the output of packet vector chunk being parsed correctly.
Output with the change :

packetChunk 58709 [0xe555]
1[chunk type] 1[symbol size] 10 01 01 01 01 01 01

statusVector statusSymbol read - 2, 1, 1, 1, 1, 1, 1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@moninom1 moninom1 merged commit 42e44be into develop Jul 12, 2024
31 checks passed
@moninom1 moninom1 deleted the fixDevelop branch July 12, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants