Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply signaling component -- rebase #2020

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

ActoryOu
Copy link
Contributor

Issue #, if available:

What was changed?

Why was it changed?

How was it changed?

  • Add Signaling component and coreJSON as external projects, import it via ExternalProject_Add, and update Signaling code to call APIs of component.

What testing was done for the changes?

  • Verified master demo on Ubuntu
  • Verified webrtc_client_test and pass all test cases.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.20690% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.57%. Comparing base (3824226) to head (cd21c9d).

Current head cd21c9d differs from pull request most recent head f060c14

Please upload reports for the commit f060c14 to get more accurate results.

Files Patch % Lines
src/source/Signaling/LwsApiCalls.c 96.20% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2020      +/-   ##
===========================================
- Coverage    88.68%   88.57%   -0.11%     
===========================================
  Files           48       48              
  Lines        12726    12657      -69     
===========================================
- Hits         11286    11211      -75     
- Misses        1440     1446       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! very excited about this rework!

@ActoryOu ActoryOu merged commit a4e293d into develop Aug 2, 2024
31 checks passed
@ActoryOu ActoryOu deleted the ApplySignalingComponentRebase branch August 2, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants