-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudwatch integration demo #2013
Open
disa6302
wants to merge
65
commits into
develop-pre-1.11.0
Choose a base branch
from
simplify-sample
base: develop-pre-1.11.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2013 +/- ##
===========================================
- Coverage 88.68% 88.67% -0.01%
===========================================
Files 48 48
Lines 12726 12726
===========================================
- Hits 11286 11285 -1
- Misses 1440 1441 +1 ☔ View full report in Codecov by Sentry. |
niyatim23
reviewed
Jun 17, 2024
niyatim23
reviewed
Jun 17, 2024
niyatim23
reviewed
Jun 17, 2024
niyatim23
reviewed
Jun 17, 2024
niyatim23
reviewed
Jun 19, 2024
niyatim23
reviewed
Jun 19, 2024
niyatim23
reviewed
Jun 19, 2024
niyatim23
reviewed
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
Added a new demo that shows integration with cloudwatch metrics and logs, pushing RTP metrics and some end to end stats with mock frames, along with demonstrating some metrics with storage. The SDK depends on AWS SDK CPP and builds the monitoring and logs component if run with
-DENABLE_AWS_SDK_INTEG=ON
. The demo project uses a config file based mechanism to set the different options in our C SDK. The demo uses the same underlying common.c and other common wrappers that our samples use todayRearranged Common.c into different files to add more clarity to the basic building blocks of the existing samples
Created a new MetricsHandling object that handles RTP stats calculation. ICE stats are still out of this and treated separately to avoid potential breaking in customer application.
Why was it changed?
How was it changed?
-DCW_CONFIG_HEADER
optionsetUpCredentialProvider
to set up IoT/long term credential provider. This is a mandatory requirement if using the samples provided with the next release - this change was made since this set up was masked behind a #ifdef block which would require sample modification, this is not conducive for the demo specifically if these decisions are taken based on a config file or even environment variable.What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.