Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply signaling component #1950

Closed
wants to merge 26 commits into from
Closed

Apply signaling component #1950

wants to merge 26 commits into from

Conversation

ActoryOu
Copy link
Contributor

Issue #, if available:

What was changed?

Why was it changed?

How was it changed?

  • Add Signaling component and coreJSON as external projects, import it via ExternalProject_Add, and update Signaling code to call APIs of component.

What testing was done for the changes?

  • Verified master demo on Ubuntu
  • Verified webrtc_client_test and pass all test cases.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 96.09121% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.60%. Comparing base (98188ff) to head (edb6fde).
Report is 1 commits behind head on develop.

Current head edb6fde differs from pull request most recent head 280e1f0

Please upload reports for the commit 280e1f0 to get more accurate results.

Files Patch % Lines
src/source/Signaling/LwsApiCalls.c 96.27% 11 Missing ⚠️
src/source/Sctp/Sctp.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1950      +/-   ##
===========================================
- Coverage    88.65%   88.60%   -0.06%     
===========================================
  Files           48       48              
  Lines        12711    12662      -49     
===========================================
- Hits         11269    11219      -50     
- Misses        1442     1443       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MushMal MushMal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A high-level review. Most comments are about the conventions. The main concern would be the amount of churn in a highly-sensitive API which has a high-level re-entrant driver code.

src/source/Signaling/Signaling.h Outdated Show resolved Hide resolved
src/source/Signaling/Signaling.c Outdated Show resolved Hide resolved
src/source/Signaling/LwsApiCalls.c Show resolved Hide resolved
src/source/Signaling/LwsApiCalls.c Outdated Show resolved Hide resolved
src/source/Signaling/LwsApiCalls.c Outdated Show resolved Hide resolved
src/source/Signaling/LwsApiCalls.c Show resolved Hide resolved
src/source/Signaling/LwsApiCalls.c Outdated Show resolved Hide resolved
src/source/Signaling/LwsApiCalls.c Outdated Show resolved Hide resolved
src/source/Signaling/LwsApiCalls.c Outdated Show resolved Hide resolved
src/source/Signaling/LwsApiCalls.c Outdated Show resolved Hide resolved
@ActoryOu
Copy link
Contributor Author

ActoryOu commented Jun 7, 2024

Thanks @MushMal for review! I'd like to update after signaling library.

@ActoryOu
Copy link
Contributor Author

Hi @MushMal,
Please help check if all comments are handled/answered if you have some time.

Thank you.

* Fix CI - unused vars

* sctp unused

* lws unused

* install
@ActoryOu
Copy link
Contributor Author

ActoryOu commented Jun 26, 2024

Closing this PR because it's unable to merge commits from develop branch. #2020 is the re-create PR.

@ActoryOu ActoryOu closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants