-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply signaling component #1950
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1950 +/- ##
===========================================
- Coverage 88.65% 88.60% -0.06%
===========================================
Files 48 48
Lines 12711 12662 -49
===========================================
- Hits 11269 11219 -50
- Misses 1442 1443 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A high-level review. Most comments are about the conventions. The main concern would be the amount of churn in a highly-sensitive API which has a high-level re-entrant driver code.
Thanks @MushMal for review! I'd like to update after signaling library. |
Hi @MushMal, Thank you. |
* Fix CI - unused vars * sctp unused * lws unused * install
Closing this PR because it's unable to merge commits from develop branch. #2020 is the re-create PR. |
Issue #, if available:
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.