From c5899841fd4b777969da495dbedbbe300b572866 Mon Sep 17 00:00:00 2001 From: Divya Sampath Kumar Date: Wed, 19 Jun 2024 13:31:42 -0700 Subject: [PATCH] sctp --- src/source/Ice/TurnConnection.c | 2 +- src/source/Sctp/Sctp.c | 3 +++ src/source/Signaling/LwsApiCalls.c | 4 ++++ tst/JitterBufferFunctionalityTest.cpp | 2 -- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/source/Ice/TurnConnection.c b/src/source/Ice/TurnConnection.c index 7e34fd67a4..26b514ad1b 100644 --- a/src/source/Ice/TurnConnection.c +++ b/src/source/Ice/TurnConnection.c @@ -1033,6 +1033,7 @@ STATUS checkTurnPeerConnections(PTurnConnection pTurnConnection) PStunAttributeChannelNumber pStunAttributeChannelNumber = NULL; UINT32 i = 0; + UNUSED_PARAM(sendStatus); // turn mutex is assumed to be locked. CHK(pTurnConnection != NULL, STATUS_NULL_ARG); for (i = 0; i < pTurnConnection->turnPeerCount; ++i) { @@ -1085,7 +1086,6 @@ STATUS checkTurnPeerConnections(PTurnConnection pTurnConnection) pTurnConnection->pControlChannel, NULL, FALSE); } } - DLOGI("Send Status set to : 0x%08x", sendStatus); CHK_STATUS(turnConnectionRefreshAllocation(pTurnConnection)); CleanUp: diff --git a/src/source/Sctp/Sctp.c b/src/source/Sctp/Sctp.c index 2af922e0cd..cbc444634d 100644 --- a/src/source/Sctp/Sctp.c +++ b/src/source/Sctp/Sctp.c @@ -366,5 +366,8 @@ INT32 onSctpInboundPacket(struct socket* sock, union sctp_sockstore addr, PVOID free(data); } + if (STATUS_FAILED(retStatus)) { + return -1; + } return 1; } diff --git a/src/source/Signaling/LwsApiCalls.c b/src/source/Signaling/LwsApiCalls.c index be2a8510e1..be747cc5be 100644 --- a/src/source/Signaling/LwsApiCalls.c +++ b/src/source/Signaling/LwsApiCalls.c @@ -37,6 +37,7 @@ INT32 lwsHttpCallbackRoutine(struct lws* wsi, enum lws_callback_reasons reason, PStateMachineState pStateMachineState; BOOL skewMapContains = FALSE; + UNUSED_PARAM(logLevel); DLOGV("HTTPS callback with reason %d", reason); // Early check before accessing the custom data field to see if we are interested in processing the message @@ -1493,6 +1494,9 @@ STATUS joinStorageSessionLws(PSignalingClient pSignalingClient, UINT64 time) PCHAR pResponseStr; UINT32 resultLen; + UNUSED_PARAM(pResponseStr); + UNUSED_PARAM(pLwsCallInfo); + UNUSED_PARAM(resultLen); CHK(pSignalingClient != NULL, STATUS_NULL_ARG); CHK(pSignalingClient->channelEndpointWebrtc[0] != '\0', STATUS_INTERNAL_ERROR); diff --git a/tst/JitterBufferFunctionalityTest.cpp b/tst/JitterBufferFunctionalityTest.cpp index 53f4e0ee48..927403541c 100644 --- a/tst/JitterBufferFunctionalityTest.cpp +++ b/tst/JitterBufferFunctionalityTest.cpp @@ -1146,11 +1146,9 @@ TEST_F(JitterBufferFunctionalityTest, timestampOverflowTest) UINT32 pktCount = 7; UINT32 startingSequenceNumber = 0; UINT32 missingSequenceNumber = 0; - UINT32 firstSequenceNumber = 0; initializeJitterBuffer(4, 0, pktCount); srand(time(0)); startingSequenceNumber = rand()%UINT16_MAX; - firstSequenceNumber = startingSequenceNumber - 1; // First frame "1" mPRtpPackets[0]->payloadLength = 1;