From 8d06ab5b334117745f1c751f336d84420c19b039 Mon Sep 17 00:00:00 2001 From: Divya Sampath Kumar Date: Thu, 13 Jun 2024 08:03:10 -0700 Subject: [PATCH] minor changes --- README.md | 4 ++-- src/source/PeerConnection/Rtp.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 72dc2a54c4..2e9734f484 100644 --- a/README.md +++ b/README.md @@ -382,7 +382,7 @@ Starting with v1.11.0, the SDK provides some knobs to optimize memory usage to t The SDK maintains an RTP rolling buffer to hold the RTP packets. This is useful to respond to NACKs and even in case of JitterBuffer. The rolling buffer size is controlled by 3 parameters: 1. MTU: This is set to a default of 1200 bytes -2. Buffer duration: This is the amount of time of media that you would like the rolling buffer to accommodate before it is overwritten due to buffer overflow. By default, the SDK sets this to 1 second +2. Buffer duration: This is the amount of time of media that you would like the rolling buffer to accommodate before it is overwritten due to buffer overflow. By default, the SDK sets this to 3 seconds 3. Highest expected bitrate: This is the expected bitrate of the media in question. The typical bitrates could vary based on resolution and codec. By default, the SDK sets this to 5 mibps for video and 1 mibps for audio The rolling buffer capacity is calculated as follows: @@ -433,7 +433,7 @@ The SDK calculates 4 different stats: For more information on these stats, refer to [AWS Docs](https://docs.aws.amazon.com/kinesisvideostreams-webrtc-dg/latest/devguide/kvswebrtc-reference.html) -The SDK disables generating these stats by default. In order to be enable the SDK to calculate these stats, the application needs to set the following field: +The SDK **disables** generating these stats by default. In order to be enable the SDK to calculate these stats, the application needs to set the following field: `configuration.kvsRtcConfiguration.enableIceStats = TRUE`. Note that this increases the memory usage by about 200KB per peer connection. ## Setup IoT diff --git a/src/source/PeerConnection/Rtp.h b/src/source/PeerConnection/Rtp.h index d943bfbcfa..dbf963a246 100644 --- a/src/source/PeerConnection/Rtp.h +++ b/src/source/PeerConnection/Rtp.h @@ -18,7 +18,7 @@ extern "C" { #define DEFAULT_VALID_INDEX_BUFFER_SIZE 1000 #define DEFAULT_PEER_FRAME_BUFFER_SIZE (5 * 1024) #define SRTP_AUTH_TAG_OVERHEAD 10 -#define MIN_ROLLING_BUFFER_DURATION_IN_SECONDS 0.1 +#define MIN_ROLLING_BUFFER_DURATION_IN_SECONDS (DOUBLE) 0.1 #define MIN_EXPECTED_BIT_RATE (DOUBLE)(102.4 * 1024) // Considering 1Kib = 1024 bits #define MAX_ROLLING_BUFFER_DURATION_IN_SECONDS (DOUBLE) 10 #define MAX_EXPECTED_BIT_RATE (DOUBLE)(240 * 1024 * 1024) // Considering 1Kib = 1024 bits