Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signaling Implementation #3

Merged
merged 26 commits into from
Jul 4, 2024
Merged

Conversation

ActoryOu
Copy link
Contributor

@ActoryOu ActoryOu commented Jun 6, 2024

Issue #, if available:
Signaling implementation.

Description of changes:
Make Signaling standalone and separate out the APIs.
Couple with standard C library and coreJSON only.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ActoryOu ActoryOu mentioned this pull request Jun 6, 2024
Signed-off-by: Gaurav Aggarwal <[email protected]>
aggarg
aggarg previously approved these changes Jun 6, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
source/include/signaling_data_types.h Show resolved Hide resolved
source/include/signaling_data_types.h Show resolved Hide resolved
source/include/signaling_data_types.h Show resolved Hide resolved
source/include/signaling_data_types.h Outdated Show resolved Hide resolved
source/signaling_api.c Outdated Show resolved Hide resolved
Signed-off-by: Gaurav Aggarwal <[email protected]>
.gitmodules Show resolved Hide resolved
README.md Show resolved Hide resolved
source/signaling_api.c Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hassanctech
hassanctech previously approved these changes Jun 17, 2024
Copy link

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ActoryOu ActoryOu dismissed stale reviews from hassanctech and aggarg via 8bd35f2 June 22, 2024 16:33
@ActoryOu ActoryOu merged commit fb54c01 into awslabs:main Jul 4, 2024
@ActoryOu ActoryOu deleted the aggarg_suggestions branch July 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants