Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on AspNetCore framework #300

Open
andrewjw1995 opened this issue May 22, 2024 · 1 comment
Open

Dependency on AspNetCore framework #300

andrewjw1995 opened this issue May 22, 2024 · 1 comment

Comments

@andrewjw1995
Copy link

I have a backround worker which is running as a .Net console application inside a mcr.microsoft.com/dotnet/runtime:6.0 container. Adding the XRay recorder to this project prevented it from starting, and it took a while for us to figure out that the package had introduced a new framework dependency that wasn't available in our runtime image. There is a separate package specifically for AspNetCore (AWSXRayRecorder.Handlers.AspNetCore) so I assumed that this package would be framework-agnostic and would only provide the API to interact with the XRay daemon.

I'm not sure why the coupling exists, but the dependency isn't documented and doesn't show up in NuGet or in Visual Studio. The only hint is that the .NetStandard version depends on Microsoft.AspNetCore.Http. Can you please add a note to the ReadMe to make this obvious?

image

@mxiamxia
Copy link

Hi @andrewjw1995 , thank you for reporting this issue. Could you help to contribute the notes in readme to prevent the further confusions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants