AwsSdk handler does not work when using a derived class from the service client

[a-jackson]

I've made my own derived class from the service client classes, e.g. AmazonS3Client so that I can use dependency injection to inject IOptions<> and call the base constructor with the appropriate AmazonS3Config. Maybe not conventional but it works.

I just added XRay and it is not recording traces for the AWS SDK calls. Looking into this I find that this guard is preventing the Pipeline Handler from being added.

serviceClientType is passed from the AmazonServiceClient constructor as this.GetType() and so is my derived type, e.g. MyAmazonS3Client. Therefore serviceClientType.BaseType is AmazonS3Client and not AmazonServiceClient.

I suggest this be changed to if (typeof(AmazonServiceClient).IsAssignableFrom(serviceClientType)) and it would not matter how many levels of derivation were used.