New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry to shown notificaitons #5179

Merged

samgst-amazon merged 1 commit into main from samgst/NotifTelemetry

Dec 9, 2024

+8 −0

Contributor

samgst-amazon commented Dec 7, 2024

Emit success metrics when notifications are successfully shown.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Description

Checklist

My code follows the code style of this project
I have added tests to cover my changes
A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.


          notification success telemetry

e7eb7db

samgst-amazon requested a review from a team as a code owner

December 7, 2024 00:21

github-actions bot commented Dec 7, 2024

Qodana Community for JVM

6 new problems were found

Inspection name	Severity	Problems
`Usage of redundant or deprecated syntax or deprecated symbols`	🔶 Warning	6

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

github-advanced-security bot found potential problems

View reviewed changes

...community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt

@@ @@ -18,6 +18,9 @@ @@
               import software.aws.toolkits.core.utils.inputStream
               import software.aws.toolkits.core.utils.warn
               import software.aws.toolkits.jetbrains.utils.notifyStickyWithData
+              import software.aws.toolkits.telemetry.Component
+              import software.aws.toolkits.telemetry.Result

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

Remove deprecated symbol import

...community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt

@@ @@ -18,6 +18,9 @@ @@
               import software.aws.toolkits.core.utils.inputStream
               import software.aws.toolkits.core.utils.warn
               import software.aws.toolkits.jetbrains.utils.notifyStickyWithData
+              import software.aws.toolkits.telemetry.Component
+              import software.aws.toolkits.telemetry.Result

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'typealias Result = MetricResult' is deprecated. Name conflicts with the Kotlin standard library

...community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt

@@ @@ -18,6 +18,9 @@ @@
               import software.aws.toolkits.core.utils.inputStream
               import software.aws.toolkits.core.utils.warn
               import software.aws.toolkits.jetbrains.utils.notifyStickyWithData
+              import software.aws.toolkits.telemetry.Component
+              import software.aws.toolkits.telemetry.Result
+              import software.aws.toolkits.telemetry.ToolkitTelemetry

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

Remove deprecated symbol import

...community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt

@@ @@ -18,6 +18,9 @@ @@
               import software.aws.toolkits.core.utils.inputStream
               import software.aws.toolkits.core.utils.warn
               import software.aws.toolkits.jetbrains.utils.notifyStickyWithData
+              import software.aws.toolkits.telemetry.Component
+              import software.aws.toolkits.telemetry.Result
+              import software.aws.toolkits.telemetry.ToolkitTelemetry

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'ToolkitTelemetry' is deprecated. Use type-safe metric builders

...community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt

@@ @@ -98,6 +101,11 @@ @@
                               BannerNotificationService.getInstance().addNotification(notificationData.id, bannerContent)
                               notifyListenerForNotification(bannerContent)
                           }
+                          ToolkitTelemetry.showNotification(

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'ToolkitTelemetry' is deprecated. Use type-safe metric builders

...community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt

@@ @@ -98,6 +101,11 @@ @@
                               BannerNotificationService.getInstance().addNotification(notificationData.id, bannerContent)
                               notifyListenerForNotification(bannerContent)
                           }
+                          ToolkitTelemetry.showNotification(
+                              id = notificationData.id,
+                              result = Result.Succeeded,

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'typealias Result = MetricResult' is deprecated. Name conflicts with the Kotlin standard library

rli approved these changes

View reviewed changes

samgst-amazon merged commit 1fd1279 into main

15 checks passed

samgst-amazon deleted the samgst/NotifTelemetry branch

December 9, 2024 21:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet