Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Chosing cancel on confirmation no longer deletes profiles (#5167) #5176

Merged
merged 4 commits into from
Dec 6, 2024
Merged

fix: Chosing cancel on confirmation no longer deletes profiles (#5167) #5176

merged 4 commits into from
Dec 6, 2024

Conversation

rickardsundin
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Fixes #5167

If the user selects cancel in the confirmation dialog, the sign out will now be aborted.

The method logoutFromSsoConnection also calls deleteSsoConnection() if connection is ProfileSsoManagedBearerSsoConnection, so removing that call from SsoLogoutAction.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ricsunSPL
fix: Chosing cancel on confirmation no longer deletes profiles (aws#5167
62598d7 
)

If the user selects cancel in the confirmation dialog, the sign out
will now be aborted.

The method logoutFromSsoConnection also calls deleteSsoConnection() if
the connection is of type ProfileSsoManagedBearerSsoConnection, so it
is does not have to be called from SsoLogoutAction.
@rickardsundin rickardsundin requested a review from a team as a code owner December 6, 2024 17:07
rli
rli approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@rli rli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution

@rli rli enabled auto-merge (squash) December 6, 2024 17:16
@rli rli merged commit 606cadf into aws:main Dec 6, 2024
11 checks passed
@rickardsundin rickardsundin deleted the bugfix-5167 branch December 6, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rli rli rli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chosing Cancel on Sign Out confirmation still deletes profiles from ~/.aws/config
3 participants
@rickardsundin @rli @ricsunSPL