Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): Fix for File Review payload and payload generation error for test and review #5166

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

ashishrp-aws
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Fix for File Review payload and payload generation error for test and review

  • Regex based error for gitignore objects throwing an error. Added error handling to escape those patterns.
  • File Review payload requirements changed in service to include only file relative path.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested review from a team as code owners December 5, 2024 03:13
@rli
Copy link
Contributor

rli commented Dec 5, 2024

please address automation comment

Comment on lines +89 to +91
parseGitIgnore().mapNotNull { pattern ->
runCatching { Regex(pattern) }.getOrNull()
}.let { addAll(it) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be simplified more but sure

@ashishrp-aws ashishrp-aws reopened this Dec 5, 2024
@ashishrp-aws ashishrp-aws reopened this Dec 5, 2024
@ashishrp-aws ashishrp-aws merged commit e4b6f0f into aws:main Dec 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants