Skip to content

Commit

Permalink
fix: Chosing cancel on confirmation no longer deletes profiles (#5167)
Browse files Browse the repository at this point in the history
If the user selects cancel in the confirmation dialog, the sign out
will now be aborted.

The method logoutFromSsoConnection also calls deleteSsoConnection() if
the connection is of type ProfileSsoManagedBearerSsoConnection, so it
is does not have to be called from SsoLogoutAction.
  • Loading branch information
ricsunSPL committed Dec 6, 2024
1 parent 0d41579 commit 62598d7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : " Chosing cancel on sign out confirmation now cancels the sign out and does not delete profiles from ~/.aws/config ([#5167](https://github.com/aws/aws-toolkit-jetbrains/issues/5167))"
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ class SsoLogoutAction(private val value: AwsBearerTokenConnection) : DumbAwareAc
AwsCoreBundle.message("gettingstarted.auth.idc.sign.out.confirmation.title"),
AwsCoreBundle.message("gettingstarted.auth.idc.sign.out.confirmation")
).yesText(AwsCoreBundle.message("general.confirm")).ask(e.project)
if (confirmDeletion) {
deleteSsoConnection(value)
if (!confirmDeletion) {
return
}
}
logoutFromSsoConnection(e.project, value)
Expand Down

0 comments on commit 62598d7

Please sign in to comment.