From 4dd995834f2964cef6a2559488eaa8205c704372 Mon Sep 17 00:00:00 2001 From: David Hasani Date: Tue, 23 Jan 2024 13:29:35 -0800 Subject: [PATCH 1/2] fix(gumby): modify metric to track errors --- telemetry/definitions/commonDefinitions.json | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index adbefe66..bdfd23e2 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -3538,8 +3538,10 @@ "type": "codeTransformSessionId", "required": true }, - { "type": "result", "required": true }, - { "type": "reason", "required": true } + { + "type": "codeTransformRuntimeError", + "required": false + } ] }, { @@ -3890,8 +3892,8 @@ "required": true }, { - "type": "reason", - "required": false + "type": "codeTransformRuntimeError", + "required": true } ] } From 081d870a701dbd72f8bd1f60f4f2f633c9f24d68 Mon Sep 17 00:00:00 2001 From: David Hasani Date: Tue, 23 Jan 2024 13:55:17 -0800 Subject: [PATCH 2/2] fix: add back result/reason --- telemetry/definitions/commonDefinitions.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index bdfd23e2..74208252 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -3541,6 +3541,14 @@ { "type": "codeTransformRuntimeError", "required": false + }, + { + "type": "result", + "required": true + }, + { + "type": "reason", + "required": true } ] }, @@ -3894,6 +3902,14 @@ { "type": "codeTransformRuntimeError", "required": true + }, + { + "type": "result", + "required": true + }, + { + "type": "reason", + "required": true } ] }