-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding OPENSSL_secure_zalloc and BIO_s_secmem #1476
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1476 +/- ##
==========================================
- Coverage 77.18% 77.17% -0.01%
==========================================
Files 426 426
Lines 71449 71452 +3
==========================================
Hits 55146 55146
- Misses 16303 16306 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not trying to nitpick the wording here. But in the PR description and final commit message, could we replace "un-secure alternatives" with something else? It could make things seem scary and insecure, but in reality we're just pointing to the traditional alternatives.
It'd also help to clarify that these are "no-ops" in the PR title, since we aren't actually implementing secure heap versions of the functions.
Description of changes:
Added BIO_s_secmem and OPENSSL_secure_zalloc. These functions are related to Secure Heaps which aren't supported in AWS-LC. Therefore, these functions use their normal alternatives (BIO_s_mem and OPENSSL_zalloc).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.