Remove SDK dependency from DynamoDBEvent #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscpinheiro
commented
Jan 9, 2024
Libraries/src/Amazon.Lambda.DynamoDBEvents/Amazon.Lambda.DynamoDBEvents.csproj
Show resolved
Hide resolved
dscpinheiro
commented
Jan 9, 2024
dscpinheiro
commented
Jan 9, 2024
normj
requested changes
Jan 10, 2024
normj
reviewed
Jan 10, 2024
normj
approved these changes
Jan 11, 2024
ashovlin
reviewed
Jan 11, 2024
| /// </li> | ||
| /// </ul> | ||
| /// </summary> | ||
| public string StreamViewType { get; set; } |
There was a problem hiding this comment.
This is an enum in the SDK, should we try to reproduce here? Though I suppose a plain .NET enum isn't as flexible as the generated constant class we use.
There was a problem hiding this comment.
We have to use string to be forward compatible with new enum values and we don't have the ConstantClass to use here. Which the ConstantClass cause other fun JSON serialization issues.
ashovlin
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws/aws-sdk-net#1116 (and internal issue
DOTNET-4497)Description of changes: Similar to #1237, this PR removes the
AWSSDK.DynamoDBv2dependency from theDynamoDBEventclass (by moving the properties from theAmazon.DynamoDBv2.Model.Recordclass).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.