Add trim support for Amazon.Lambda.Annotations #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
commented
Nov 14, 2023
| @@ -14,9 +14,9 @@ public class HttpResultsTest | |||
| [Fact] | |||
| public void OkNoBody() | |||
| { | |||
| var result = HttpResults.Ok(); | |||
| var result = () => HttpResults.Ok(); | |||
There was a problem hiding this comment.
This is the change mention in the description where ValidateResult runs across the different combinations of API Gateway responses. The unit tests were change to pass in a Func instead of a single instance so we didn't reuse the same IHttpResult for each iteration in ValidateResult.
normj
commented
Nov 14, 2023
| @@ -162,9 +162,9 @@ public void Execute(GeneratorExecutionContext context) | |||
| } | |||
| } | |||
|
|
|||
| var serializerString = GetSerializerAttribute(context, lambdaMethodModel); | |||
| var serializerInfo = GetSerializerInfoAttribute(context, lambdaMethodModel); | |||
There was a problem hiding this comment.
This was changed to GetSerializerInfoAttribute because now we are getting the optional JsonSerializerContext as well as the serializer name.
ashovlin
reviewed
Nov 14, 2023
Libraries/test/TestExecutableServerlessApp/SourceGenerationSerializationExample.cs
Show resolved
Hide resolved
Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Models/LambdaSerializerInfo.cs
Show resolved
Hide resolved
ashovlin
approved these changes
Nov 14, 2023
jeastham1993
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add trimming support for Lambda Annotations. Using trimming requires users to use the
SourceGeneratorLambdaJsonSerializerlambda serializer so that JSON serialization is not being done via reflection.The
HttpResultsclass was modified to use theJsonSerializerContextthat theSourceGeneratorLambdaJsonSerializeris registered with via the generic parameter. It uses theJsonSerializerContextto serialize the HTTP response body. It means the user has to register any types returned via HttpResults in the body with theJsonSerializerContextvia theJsonSerializableattribute.Another slight change to
HttpResultsis it used to handle the serialization as soon as part of the constructor but there is no way to get theJsonSerializerContextinto the constructor. So I changed body serialization to the when we serialize theHttpResults. This affected the unit tests because they were unintended reusing the sameIHttpResultfor each serialization format. So I change the test to create a new instance every time we run the serializer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.