Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for executable assemblies when using Lambda Annotations #1571

Closed
1 of 2 tasks
jeastham1993 opened this issue Aug 21, 2023 · 5 comments
Closed
1 of 2 tasks

Support for executable assemblies when using Lambda Annotations #1571

jeastham1993 opened this issue Aug 21, 2023 · 5 comments
Labels
annotations feature-request A feature should be added or improved. p2 This is a standard priority issue queued

Comments

@jeastham1993
Copy link
Contributor

Describe the feature

The current implementation of Lambda Annotations relies on using the class based handler approach. Add support for executable assemblies so that runtimes that require the Lambda runtime to be manually bootstrapped can also be used. Behind the scenes, this will generate the static main method used as the entrypoint.

Use Case

As a developer, I want to use non-managed runtime versions of .NET but this requires me to understand how to bootstrap the runtime manually.

Proposed Solution

Update the existing source generator to generate a Program.cs file if targetting an executable assembly. If there are multiple handlers in the same Lambda function add an Environment Variable to determine which handler is used.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

N/A, this is a new feature.

Targeted .NET Platform

.NET 6, .NET Standard 2.0

Operating System and version

All
@jeastham1993 jeastham1993 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 21, 2023
@jeastham1993
Copy link
Contributor Author

I have a PR ready to raise for this, just looking to get the tests working.

@ashishdhingra
Copy link
Contributor

Needs review with the team. @jeastham1993 Feel free to contribute PR.

@ashishdhingra ashishdhingra added needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Aug 21, 2023
@jeastham1993 jeastham1993 mentioned this issue Aug 21, 2023
Merged
@jeastham1993
Copy link
Contributor Author

@ashishdhingra PR raised
#1573

@ashishdhingra ashishdhingra added p2 This is a standard priority issue queued and removed needs-review labels Aug 23, 2023
normj pushed a commit that referenced this issue Nov 13, 2023
@normj
#1571 Add annotations support for executable assemblies
4bd94a2
@normj
Copy link
Member

normj commented Dec 7, 2023

Closing the issue now that the PR has been merged and released.

@normj normj closed this as completed Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
annotations feature-request A feature should be added or improved. p2 This is a standard priority issue queued
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@normj @jeastham1993 @ashishdhingra