Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tumbling Window Events for Kinesis & Dynamo #1538

Closed
1 of 2 tasks
benlongo opened this issue Jun 27, 2023 · 4 comments
Closed
1 of 2 tasks

Tumbling Window Events for Kinesis & Dynamo #1538

benlongo opened this issue Jun 27, 2023 · 4 comments
Assignees
Labels
feature-request A feature should be added or improved. module/lambda-client-lib p2 This is a standard priority issue queued

Comments

@benlongo
Copy link

Describe the feature

The dotnet SDK appears to be missing this event type https://javadoc.io/static/com.amazonaws/aws-lambda-java-events/3.11.2/com/amazonaws/services/lambda/runtime/events/KinesisTimeWindowEvent.html

Use Case

I'm trying to create a tumbling window event function in dotnet for kinesis.

Proposed Solution

Implement KinesisTimeWindowEvent

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

Targeted .NET Platform

.NET 7

Operating System and version

Windows 11

@benlongo benlongo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 27, 2023
@ashishdhingra
Copy link
Contributor

ashishdhingra commented Jun 27, 2023

@benlongo Thanks for submitting feature request. This needs to be reviewed with the team. Feel free to contribute PR with associated test case which could be reviewed by the team.

Kinesis Time window event reference: KinesisTimeWindowEvent

Thanks,
Ashish

@ashishdhingra ashishdhingra added needs-review p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jun 27, 2023
@benlongo
Copy link
Author

I misunderstood how tumbling windows behaved so I don't need this anymore, but it still is a gap in the SDK so I'll leave the issue open.

@ashishdhingra
Copy link
Contributor

This has been implemented in Amazon.Lambda.DynamoDBEvents v2.2.0 and Amazon.Lambda.KinesisEvents v2.1.0.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/lambda-client-lib p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

2 participants