Support image tag property in lambda package-ci command

[NickDarvey]

-it | --image-tag looks like it is supported in package but not package-ci. Is this as designed?

aws-extensions-for-dotnet-cli/src/Amazon.Lambda.Tools/Commands/PackageCommand.cs

Line 31 in 9639f8f

LambdaDefinedCommandOptions.ARGUMENT_IMAGE_TAG,

aws-extensions-for-dotnet-cli/src/Amazon.Lambda.Tools/Commands/PackageCICommand.cs

Lines 26 to 37 in 9639f8f

	public static readonly IList<CommandOption> PackageCICommandOptions = BuildLineOptions(new List<CommandOption>
	{
	CommonDefinedCommandOptions.ARGUMENT_CONFIGURATION,
	CommonDefinedCommandOptions.ARGUMENT_FRAMEWORK,
	CommonDefinedCommandOptions.ARGUMENT_MSBUILD_PARAMETERS,
	LambdaDefinedCommandOptions.ARGUMENT_CLOUDFORMATION_TEMPLATE,
	LambdaDefinedCommandOptions.ARGUMENT_CLOUDFORMATION_TEMPLATE_SUBSTITUTIONS,
	LambdaDefinedCommandOptions.ARGUMENT_OUTPUT_CLOUDFORMATION_TEMPLATE,
	LambdaDefinedCommandOptions.ARGUMENT_S3_BUCKET,
	LambdaDefinedCommandOptions.ARGUMENT_S3_PREFIX,
	LambdaDefinedCommandOptions.ARGUMENT_DISABLE_VERSION_CHECK
	});

Describe the Feature

Allowing users to specify the tag for my Docker image using the --image-tag switch.

Is your Feature Request related to a problem?

The generated image tag (taken from the project name) might not be the one that's desired.

Proposed Solution

Unsure. Is this code base up to date with what is published as a dotnet tool?

Describe alternatives you've considered

Accepting life as-is.
Edit: It appears to work when set in aws-lambda-tools.defaults.json.

Additional Context

Environment

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

---

This is a 🚀 Feature Request

[ashishdhingra]

Not sure if this is feasible and how the image tag could be specified in the serverless.template. Needs more investigation.

[NickDarvey]

I'm not sure I understand. Right now, by default, here's a name:tag combo being generated from the project name and used for the Docker image build and push. You can already manually set it using aws-lambda-tools-defaults.json, this feature is a request to an option to specify it via a command line parameter.

[github-actions]

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

[normj]

Because the package-ci command is potentially packaging multiple .NET projects that referenced in the CloudFormation template you need to set the image tag in there as well. If we had an --image-tag switch for for the package-ci command it would use the same tag for all of the containers being built from the CloudFormation template overwriting each other. Here is an example of how to set the image tag in the template.

[github-actions]

This issue has not received a response in 5 days. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled.

[NickDarvey]

@normj

If we had an --image-tag switch for for the package-ci command it would use the same tag for all of the containers being built from the CloudFormation template overwriting each other.

Is that what happens when you set it via aws-lambda-tools.defaults.json? Maybe the tool should error if it’s used with multiple projects when an image tag is set. Then an image tag switch could be added which would, similarly, error if used with multiple projects.

[normj]

@NickDarvey Interesting the image-tag being used from aws-lambda-tools.defaults.json is actually an accidental side effect since the package-ci command eventually forwards into the package command's code for each project it is bundling into an image. Although that image-tag isn't being used solely, the package-ci command does inject the CloudFormation resource name into the image tag to make it unique. Are you okay with the tag not being exactly as you entered. I guess what I'm asking is would you be okay if we exposed an image tag prefix/suffix switch but we still used our code to make sure the full tag name is unique?

[NickDarvey]

Interesting the image-tag being used from aws-lambda-tools.defaults.json is actually an accidental side effect since the package-ci command eventually forwards into the package command's code for each project it is bundling into an image.

Ahh I see.

I guess what I'm asking is would you be okay if we exposed an image tag prefix/suffix switch but we still used our code to make sure the full tag name is unique?

That would work for me :)