Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max frame size #130

Open
mattsb42-aws opened this issue Dec 17, 2018 · 0 comments
Open

Fix max frame size #130

mattsb42-aws opened this issue Dec 17, 2018 · 0 comments

Comments

@mattsb42-aws
Copy link
Member

Problem

Per the message format specification, the frame size is an unsigned 32-bit integer. No other limits are set on this value. As such, the max frame size is 2^32 - 1, not 2^31 - 1 as currently defined. It looks like this snuck in as an implementation detail from the Java client, where the frame size is limited by MAX_INT.

Solution

Fix the defined value to be 2^32 - 1 and add tests that verify that frames of size 2^31 - 1 < frame_size <= 2^32 - 1 work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant