Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document configuration options #47

Open
miparnisari opened this issue Jun 23, 2023 · 0 comments
Open

Document configuration options #47

miparnisari opened this issue Jun 23, 2023 · 0 comments

Comments

@miparnisari
Copy link

miparnisari commented Jun 23, 2023

Can you please add comments to each Configuration parameter explaining what it does and what are the recommended values?

type Config struct {
MaxPendingConnectionsPerHost int
ClusterUpdateThreshold time.Duration
ClusterUpdateInterval time.Duration
IdleConnectionReapDelay time.Duration
ClientHealthCheckInterval time.Duration
HostPorts []string
Region string
Credentials *credentials.Credentials
DialContext func(ctx context.Context, network string, address string) (net.Conn, error)
connConfig connConfig
SkipHostnameVerification bool
logger aws.Logger
logLevel aws.LogLevelType
}

For example, MaxPendingConnectionsPerHost is renamed to maxConcurrentConnAttempts here, and the default is 10. What are the consequences if we increase this to 10000? Etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant