Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SCPs only on change #171

Open
ceejaey opened this issue Sep 5, 2023 · 1 comment
Open

Modify SCPs only on change #171

ceejaey opened this issue Sep 5, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ceejaey
Copy link

ceejaey commented Sep 5, 2023

Is your feature request related to a problem? Please describe.
If we deploy any change using CfCT, our security team alerts that the Service Control Policies are always be redeployed/updated, regardless if no change was made to SCPs (e.g. changing CloudFormation resource)

We had initially designed one of our CloudTrail alert signals to detect changes to SCPs, but this is quite noisy during initial build phase, so might need to supress.

Describe the feature you'd like
Only deploy/update SCPs if a difference exists between the SCPs already deployed and those passed to the SCP state machine

Additional context
We use CfCT for:

  • deployment of Service Control Policies across all accounts in our Control Tower environment
  • deployment of any components within our Core OU (logging/audit)
  • deployment of common shared components or configuration that we'd expect to exist within any AWS account in our Organisation (e.g. SSM params for account numbers for use within Cloudformation scripts/Configuration of S3 bucket account policy/IAM policy etc)

We centralise all our CloudTrail activity to central logging account, and this is monitored by our security team for indicators of compromise.

We use CfCT as a deployment mechanism, with a CodeCommit repo that has a pipeline which publishes changes to the main branch to the bucket which will trigger CfCT.

@ceejaey ceejaey added the enhancement New feature or request label Sep 5, 2023
@snebhu3
Copy link

snebhu3 commented Sep 6, 2023

@ceejaey thanks for bringing this up.
I have created an internal backlog to address this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants