Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3-Version or Checksum Check to BuildSpec #150

Open
akefirad opened this issue Feb 19, 2023 · 1 comment
Open

Add S3-Version or Checksum Check to BuildSpec #150

akefirad opened this issue Feb 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@akefirad
Copy link

Is your feature request related to a problem? Please describe.
Looking at the logs, I can see:

[Container] 2023/02/18 19:32:11 Running command aws s3 cp --quiet s3://control-tower-cfct-assets-prod/customizations-for-aws-control-tower/v2.5.2/custom-control-tower-scripts.zip $current

Essentially it's downloading the scripts from the bucket (which I assume is maintained by you guys?)
The problem is that there's no way to verify that the zip file is not tampered.

Describe the feature you'd like
Would be nice to either pin down the S3 version of the zip file (which requires to use s3api command) or to check the downloaded file checksum.

Additional context
N/A

@akefirad akefirad added the enhancement New feature or request label Feb 19, 2023
@akefirad akefirad changed the title Add Checksum or S3-Version Check to BuildSpec Add S3-Version or Checksum Check to BuildSpec Feb 19, 2023
@balltrev
Copy link

Hey @akefirad thanks for bringing this up. I've gone ahead and made a backlog with the team to consider increasing the security posture here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants