Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Run pydantic v2 workflow only for features using pydantic #3349

Closed
1 of 2 tasks
heitorlessa opened this issue Nov 16, 2023 · 3 comments · Fixed by #3360
Closed
1 of 2 tasks

Maintenance: Run pydantic v2 workflow only for features using pydantic #3349

heitorlessa opened this issue Nov 16, 2023 · 3 comments · Fixed by #3360
Assignees
Labels
internal Maintenance changes

Comments

@heitorlessa
Copy link
Contributor

Why is this needed?

Our CI times doubled as GH has a limit of concurrent workflows run, increasing our lead time.

Which area does this relate to?

No response

Solution

Short-term: change paths in Pydantic V2 workflow to only use Event Handler, Parser, and Batch.

Medium-term: if CI time continues to be high, we use nox like solution to dynamically swap Pydantic version at runtime (no additional workflow).

Long-term: Launch v3 with Pydantic v2 and drop v1.

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Nov 16, 2023
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Nov 16, 2023
@leandrodamascena
Copy link
Contributor

Hey @heitorlessa! Our tests takes +-30s to complete and I think we can start removing lint/static checking. Let me send the PR to check this.

image

Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Nov 17, 2023
Copy link
Contributor

This is now released under 2.27.1 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Nov 21, 2023
@heitorlessa heitorlessa moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
Status: Shipped
2 participants