Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Native middleware 'SchemaValidationMiddleware' has invalid link #3246

Closed
1 task done
jvnsg opened this issue Oct 24, 2023 · 3 comments · Fixed by #3247
Closed
1 task done

Docs: Native middleware 'SchemaValidationMiddleware' has invalid link #3246

jvnsg opened this issue Oct 24, 2023 · 3 comments · Fixed by #3247
Labels
documentation Improvements or additions to documentation

Comments

@jvnsg
Copy link
Contributor

jvnsg commented Oct 24, 2023

What were you searching in the docs?

Missing documentation for native middleware 'SchemaValidationMiddleware'. The link given in Doc-EventHandler-ApiGatreway is invalid. Therefor the use of 'SchemaValidationMiddleware' isnt't clear.

Is this related to an existing documentation section?

| [SchemaValidationMiddleware](/api/event_handler/middlewares/schema_validation.html){target="_blank"} | Validates API request body and response against JSON Schema, using [Validation utility](../../utilities/validation.md){target="_blank"} |

How can we improve?

Add valid documentation for 'SchemaValidationMiddleware'.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@jvnsg jvnsg added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Oct 24, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 24, 2023

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@leandrodamascena
Copy link
Contributor

Hey @jvnsg! Thanks for opening this issue and in fact the link is wrong. This should be https://docs.powertools.aws.dev/lambda/python/latest/api/event_handler/middlewares/schema_validation.html.

What do you think about sending a Pull Request to fix this? We'd love to have your first contribution here.

@leandrodamascena leandrodamascena removed the triage Pending triage from maintainers label Oct 24, 2023
@leandrodamascena leandrodamascena moved this from Triage to Pending customer in Powertools for AWS Lambda (Python) Oct 24, 2023
@leandrodamascena leandrodamascena linked a pull request Oct 24, 2023 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from Pending customer to Coming soon in Powertools for AWS Lambda (Python) Oct 24, 2023
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Shipped
Development

Successfully merging a pull request may close this issue.

2 participants