Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: replace PAT_GITHUB_BOT_USER and target repo in e2e #25

Open
dreamorosi opened this issue May 7, 2024 · 0 comments
Open

Comments

@dreamorosi
Copy link
Collaborator

Summary

As part of #24 we have setup e2e tests for the packages in this repo. These tests are expected to create a GitHub issue and to do so cross-repo we need a GitHub Personal Access Token.

To speed things up I have used my own account, however as soon as feasible we should create and use a PAT from @aws-powertools-bot instead.

Likewise, right now we are using this repo as destination for the issue, we should consider instead setting one of our private staging repos.

Why is this needed?

For the PAT change, this will make it so that the automated actions taken by an user marked as bot.

For the destination change, it'll allow us to run tests without crowding this repo issues.

Solution

Log in into the bot user, and create a PAT. Then in the settings of this repo, update the environment secret value to the new PAT.

For the destination repo, update the .github/workflows/quality_check.yml file jobs.quality_check.env section and add a E2E_DESTINATION_REPOSITORY variable with the new destination repo.

Future readers

Please react with 👍 and your use case to help us understand customer demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant