-
Notifications
You must be signed in to change notification settings - Fork 596
/
EventsLogGroupName.py
62 lines (50 loc) · 2.22 KB
/
EventsLogGroupName.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
"""
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: MIT-0
"""
import json
from cfnlint._typing import RuleMatches
from cfnlint.rules import CloudFormationLintRule, RuleMatch
from cfnlint.template import Template
class EventsLogGroupName(CloudFormationLintRule):
"""Check if the settings of multiple subscriptions are included for one LogGroup"""
id = "E2529"
shortdesc = (
"Check for SubscriptionFilters have beyond 2 attachments to a CloudWatch Log"
" Group"
)
description = (
"The current limit for a CloudWatch Log Group is they can have 2 subscription"
" filters. We will look for duplicate LogGroupNames inside Subscription Filters"
" and make sure they are within 2. This doesn't account for any other"
" subscription filters getting set."
)
source_url = "https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#user-content-cloudwatchlogs"
tags = ["resources", "lambda"]
limit = 2
def check_events_subscription_duplicated(self, cfn):
"""Check if Lambda Events Subscription is duplicated"""
matches = []
message = (
f"You can only have {self.limit} Subscription Filters per CloudWatch Log"
" Group"
)
log_group_paths = self.__get_log_group_name_list(cfn)
for _, c in log_group_paths.items():
if len(c) > self.limit:
matches.append(RuleMatch(["Resources", c[2]], message))
return matches
def __get_log_group_name_list(self, cfn):
log_group_paths = {}
for value in cfn.get_resources("AWS::Logs::SubscriptionFilter").items():
prop = value[1].get("Properties")
log_group_name = json.dumps(prop.get("LogGroupName"))
if log_group_name not in log_group_paths:
log_group_paths[log_group_name] = []
log_group_paths[log_group_name].append(value[0])
return log_group_paths
def match(self, cfn: Template) -> RuleMatches:
"""Check if Lambda Events Subscription is duplicated"""
matches = []
matches.extend(self.check_events_subscription_duplicated(cfn))
return matches