-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logging): CloudWatch Plugin 16KB page size support #2919
base: main
Are you sure you want to change the base?
Conversation
Need to test a few scenarios given that this isn't just a version bump, but a new library for SqlCipher.
|
Testing scenario:
Validated:
|
Oh also, validated that configuring the cloudwatch plugin to start syncing logs up to CloudWatch successfully uploaded the logs and I could see it in the console :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
+ Coverage 44.01% 44.04% +0.02%
==========================================
Files 926 932 +6
Lines 30485 30601 +116
Branches 4351 4524 +173
==========================================
+ Hits 13419 13478 +59
- Misses 15601 15622 +21
- Partials 1465 1501 +36
|
…e-support' into tjroach/cloudwatch-16kb-page-size-support
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.