Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change of warmup behavior in BenchmarkTools #70

Closed
gdalle opened this issue Feb 22, 2024 · 2 comments · Fixed by #71
Closed

Change of warmup behavior in BenchmarkTools #70

gdalle opened this issue Feb 22, 2024 · 2 comments · Fixed by #71

Comments

@gdalle
Copy link

gdalle commented Feb 22, 2024

I think this will affect your (awesome) package once I merge it

JuliaCI/BenchmarkTools.jl#330
@awadell1
Copy link
Owner

awadell1 commented Feb 22, 2024 •
edited
Loading

Thank you! It'll break a few tests (I test for no warnings during warmup, which now has a depreciation warning), but everything works functionally.

Appreciate the heads-up!

@gdalle
Copy link
Author

gdalle commented Feb 28, 2024

merged it!

@awadell1 awadell1 mentioned this issue Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Warmup awadell1/PkgJogger.jl
2 participants
@awadell1 @gdalle