Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a helper library for utilities specific to tests #1825

Open
harish-24 opened this issue Jul 17, 2020 · 2 comments
Open

Create a helper library for utilities specific to tests #1825

harish-24 opened this issue Jul 17, 2020 · 2 comments
Assignees

Comments

@harish-24
Copy link
Member

More often than not we use a lot of code which is repetitive across tests. The obvious solution is to use avocado framework, and yes we should continue to do so. But there are still quite a few use cases which still cannot go into avocado but still repeats per test.

A basic example would be steps to install packages for each test. There should be a few more which can still be moved as helpers.
@narasimhan-v @PraveenPenguin Your thoughts please

@narasimhan-v
Copy link
Member

My thoughts:

Push as much common code to avocado utils as possible, as is the current model.

When some code is common but can not go into avocado, it is better to have a discussion in avocado and come up with a semi-util / helper model for it in avocado itself. There are more pros to doing that than this approach of helpers. Once we have a good number of helpers which can not go into avocado, then we can think of having a helper in misc-tests.

This discussion has come up in the past, and has not gained enough momentum for further action I guess. So, I suggest to start with listing the most convincing helper modules and start an RFC in avocado, and based on that we can revisit this issue. We can start listing such helpers there.

Thoughts welcome.

@PraveenPenguin
Copy link
Member

I think this we discuss i think some time back as well as @narasimhan-v said please try to push everything in avocado itself and this repo only for test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants