From dab22dd79c8a40f9e85684aa8dae1612c421401f Mon Sep 17 00:00:00 2001
From: ruijialin <ruijia.lin@avalabs.org>
Date: Wed, 23 Oct 2024 13:03:11 -0400
Subject: [PATCH] chore: update builder test with convertSubnetTx

---
 src/vms/pvm/etna-builder/builder.test.ts | 69 ++++++++++++++++++++++++
 src/vms/pvm/etna-builder/builder.ts      |  2 +
 2 files changed, 71 insertions(+)

diff --git a/src/vms/pvm/etna-builder/builder.test.ts b/src/vms/pvm/etna-builder/builder.test.ts
index 8859ead61..253c241a9 100644
--- a/src/vms/pvm/etna-builder/builder.test.ts
+++ b/src/vms/pvm/etna-builder/builder.test.ts
@@ -38,6 +38,8 @@ import {
   Signer,
   TransferSubnetOwnershipTx,
   AddPermissionlessDelegatorTx,
+  ConvertSubnetTx,
+  ProofOfPossession,
 } from '../../../serializable/pvm';
 import { BaseTx as AvaxBaseTx } from '../../../serializable/avax';
 import { hexToBuffer } from '../../../utils';
@@ -48,6 +50,7 @@ import {
   newAddPermissionlessValidatorTx,
   newAddSubnetValidatorTx,
   newBaseTx,
+  newConvertSubnetTx,
   newCreateChainTx,
   newCreateSubnetTx,
   newExportTx,
@@ -67,6 +70,8 @@ import {
   proofOfPossession,
 } from '../../../fixtures/pvm';
 import type { FeeState } from '../models';
+import { ConvertSubnetValidator } from '../../../serializable/fxs/pvm/convertSubnetValidator';
+import { PChainOwner } from '../../../serializable/fxs/pvm/pChainOwner';
 
 const addTransferableAmounts = (
   transferableItems:
@@ -1007,4 +1012,68 @@ describe('./src/vms/pvm/etna-builder/builder.test.ts', () => {
       expectTxs(unsignedTx.getTx(), expectedTx);
     });
   });
+
+  describe('ConvertSubnetTx', () => {
+    it('should create an ConvertSubnetTx', () => {
+      const utxoInputAmt = BigInt(50 * 1e9);
+      const utxos = testUtxos();
+      const signer = new ProofOfPossession(
+        blsPublicKeyBytes(),
+        blsSignatureBytes(),
+      );
+      const pChainOwner = PChainOwner.fromNative([testAddress1], 1);
+
+      const validator = ConvertSubnetValidator.fromNative(
+        nodeId,
+        BigInt(1 * 1e9),
+        BigInt(0 * 1e9),
+        signer,
+        pChainOwner,
+        pChainOwner,
+      );
+
+      const unsignedTx = newConvertSubnetTx(
+        {
+          fromAddressesBytes,
+          feeState,
+          utxos,
+          subnetAuth: [0],
+          subnetId: Id.fromHex(testSubnetId).toString(),
+          address: testAddress1,
+          validators: [validator],
+          chainId: 'h5vH4Zz53MTN2jf72axZCfo1VbG1cMR6giR4Ra2TTpEmqxDWB',
+        },
+        testContext,
+      );
+
+      const { baseTx } = unsignedTx.getTx() as ConvertSubnetTx;
+      const { inputs, outputs } = baseTx;
+
+      const [amountConsumed, expectedAmountConsumed, expectedFee] =
+        checkFeeIsCorrect({
+          unsignedTx,
+          inputs,
+          outputs,
+          feeState,
+        });
+
+      expect(amountConsumed).toEqual(expectedAmountConsumed);
+
+      const expectedTx = new ConvertSubnetTx(
+        AvaxBaseTx.fromNative(
+          testContext.networkID,
+          testContext.pBlockchainID,
+          [getTransferableOutForTest(utxoInputAmt - expectedFee)],
+          [getTransferableInputForTest(utxoInputAmt)],
+          new Uint8Array(),
+        ),
+        Id.fromHex(testSubnetId),
+        Id.fromString('h5vH4Zz53MTN2jf72axZCfo1VbG1cMR6giR4Ra2TTpEmqxDWB'),
+        new Bytes(testAddress1),
+        [validator],
+        Input.fromNative([0]),
+      );
+      expectTxs(unsignedTx.getTx(), expectedTx);
+    });
+  });
 });
diff --git a/src/vms/pvm/etna-builder/builder.ts b/src/vms/pvm/etna-builder/builder.ts
index ee526635d..e3bc46543 100644
--- a/src/vms/pvm/etna-builder/builder.ts
+++ b/src/vms/pvm/etna-builder/builder.ts
@@ -76,6 +76,7 @@ import {
 import { spend } from './spend';
 import { useSpendableLockedUTXOs, useUnlockedUTXOs } from './spend-reducers';
 import type { ConvertSubnetValidator } from '../../../serializable/fxs/pvm/convertSubnetValidator';
+import { INTRINSIC_CONVERT_SUBNET_TX_COMPLEXITIES } from '../txs/fee/constants';
 
 /**
  * Creates OutputOwners used for change outputs with the specified
@@ -1391,6 +1392,7 @@ export const newConvertSubnetTx: TxBuilderFn<NewConvertSubnetTxProps> = (
   }
 
   const complexity = addDimensions(
+    INTRINSIC_CONVERT_SUBNET_TX_COMPLEXITIES,
     bytesComplexity,
     validatorComplexity,
     authComplexity,